liuzh91 commented on a change in pull request #16922: Update LoggingHandler to
support logging per interval
URL: https://github.com/apache/incubator-mxnet/pull/16922#discussion_r353664890
##########
File path: python/mxnet/gluon/contrib/estimator/event_handler.py
##########
@@ -241,17 +241,16 @@ class LoggingHandler(TrainBegin, TrainEnd, EpochBegin,
EpochEnd, BatchBegin, Bat
"""
LOG_PER_EPOCH = 1
- LOG_PER_BATCH = 2
- LOG_PER_INTERVAL = 3
+ LOG_PER_INTERVAL = 2
def __init__(self, verbose=LOG_PER_EPOCH,
train_metrics=None,
val_metrics=None,
log_interval=1):
Review comment:
It can be done in this way, but I think verbose is more user friendly. If we
use `log_interval=None` in the logging handler, user may need to understand
this hack from the documentation. I think we should leave verbose here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
