liuzh91 commented on a change in pull request #16922: Update LoggingHandler to
support logging per interval
URL: https://github.com/apache/incubator-mxnet/pull/16922#discussion_r354082884
##########
File path: python/mxnet/gluon/contrib/estimator/event_handler.py
##########
@@ -241,17 +241,16 @@ class LoggingHandler(TrainBegin, TrainEnd, EpochBegin,
EpochEnd, BatchBegin, Bat
"""
LOG_PER_EPOCH = 1
- LOG_PER_BATCH = 2
- LOG_PER_INTERVAL = 3
+ LOG_PER_INTERVAL = 2
def __init__(self, verbose=LOG_PER_EPOCH,
train_metrics=None,
val_metrics=None,
log_interval=1):
Review comment:
Then the type of the variable will be confusing. In the comments of
`LoggingHandler`, we have `log_interval: int, default 1`. If we assign a value
other than integer type, user may complain about it.
Even though there is no type declaration in python, I believe it is still
convention that a variable should only be of one type. It is also beneficial
for maintenance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
