leezu commented on a change in pull request #16971: Extend estimator.evaluate()
to support event handlers
URL: https://github.com/apache/incubator-mxnet/pull/16971#discussion_r354124837
##########
File path: python/mxnet/gluon/contrib/estimator/event_handler.py
##########
@@ -305,15 +293,22 @@ def batch_end(self, estimator, *args, **kwargs):
def epoch_begin(self, estimator, *args, **kwargs):
if self.verbose >= self.LOG_PER_EPOCH:
+ is_training = False
+ for metric in self.metrics:
+ if 'training' in metric.name:
Review comment:
Please add a comment and describe that this test always works thanks to the
hack in `Estimator.__init__`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
