leezu commented on a change in pull request #16971: Extend estimator.evaluate()
to support event handlers
URL: https://github.com/apache/incubator-mxnet/pull/16971#discussion_r354125717
##########
File path: python/mxnet/gluon/contrib/estimator/estimator.py
##########
@@ -202,13 +206,17 @@ def _add_default_training_metrics(self):
self._train_metrics.append(metric_loss(loss_name))
for metric in self._train_metrics:
- metric.name = "training " + metric.name
+ metric.name = 'training ' + metric.name
Review comment:
Please add a comment describing that this is needed for `LoggingHandler` to
improve the logging output and to detect if it is in training or evaluation
mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
