eric-haibin-lin commented on a change in pull request #16700: [Profiler] Make
the trace name unique
URL: https://github.com/apache/incubator-mxnet/pull/16700#discussion_r357731510
##########
File path: src/engine/naive_engine.cc
##########
@@ -223,6 +223,9 @@ class NaiveEngine final : public Engine {
shutdown_phase_.store(true);
}
+ const char *GetCachedName(std::string opr_names) override {
Review comment:
This leads to build failure:
```
src/engine/naive_engine.cc: In member function 'virtual const char*
mxnet::engine::NaiveEngine::GetCachedName(std::__cxx11::string)':
src/engine/naive_engine.cc:227:3: error: no return statement in function
returning non-void [-Werror=return-type]
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
