eric-haibin-lin commented on a change in pull request #16700: [Profiler] Make
the trace name unique
URL: https://github.com/apache/incubator-mxnet/pull/16700#discussion_r357735849
##########
File path: src/profiler/profiler.cc
##########
@@ -121,6 +121,7 @@ void Profiler::SetState(ProfilerState state) {
set_paused(false);
} else {
set_paused(true);
+ cached_seg_opr_names_.clear();
Review comment:
This is not thread safe. We may change the profiler state while some ops are
still being executed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
