TaoLv commented on a change in pull request #17214: [tvmop] support cuda
multi-arch compilation
URL: https://github.com/apache/incubator-mxnet/pull/17214#discussion_r363144487
##########
File path: CMakeLists.txt
##########
@@ -840,7 +841,7 @@ install(TARGETS ${MXNET_INSTALL_TARGETS}
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/dlpack/include/
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/dmlc-core/include/
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
-if(USE_MKLDNN)
+if(INSTALL_MKLDNN)
Review comment:
I see. So both MXNet and TVM have this `USE_MKLDNN` flag but you don't want
to enable it in TVM. Does the `<PARENT_SCOPE>` help here?
https://cmake.org/cmake/help/latest/command/set.html#set-normal-variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
