leezu commented on a change in pull request #17214: [tvmop] support cuda
multi-arch compilation
URL: https://github.com/apache/incubator-mxnet/pull/17214#discussion_r363240314
##########
File path: CMakeLists.txt
##########
@@ -840,7 +841,7 @@ install(TARGETS ${MXNET_INSTALL_TARGETS}
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/dlpack/include/
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/dmlc-core/include/
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
-if(USE_MKLDNN)
+if(INSTALL_MKLDNN)
Review comment:
@yzhliu Yes, parent scope is affected in the current case. To fix this
problem, you can make use of CMakes function scopes. Ie define a new function
insede the BuildTVM.cmake, and do all variable changes inside that function.
You can take
https://github.com/apache/incubator-mxnet/blob/3e638b4fc4de959c7afc614facc336a796347c9d/CMakeLists.txt#L407-L414
as a reference
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
