haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r364600122
##########
File path: src/operator/mxnet_op.h
##########
@@ -759,6 +759,17 @@ struct backward_grad {
}
};
+template<typename OP, int req>
+struct op_with_req2 {
+ typedef OP Operation;
+
+ /*! \brief input is one tensor */
+ template<typename DType, typename IType>
Review comment:
better use `OType` and `IType`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
