haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r364603714
##########
File path: src/operator/tensor/elemwise_binary_op.h
##########
@@ -525,6 +525,66 @@ class ElemwiseBinaryOp : public OpBase {
});
}
+ template<typename xpu, typename OP>
+ static void Compute2(const nnvm::NodeAttrs &attrs,
Review comment:
better name for both `Compute2` and `Compute3`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
