JiangZhaoh commented on issue #17255: [DO NOT REVIEW]Set np default dtype( 
float32 <-> float64)
URL: https://github.com/apache/incubator-mxnet/pull/17255#issuecomment-572460479
 
 
   > This PR changes so many things and it feels odd. I'm afraid it will cause 
quite some confusion when people explicitly set the type, change the default 
and then wonder when it's not being used - the UX wouldn't be great
   Could you please tell me how can I finish this function if I don't change 
these files? I know some files maybe don't need to change, but I think most of 
them definitely need to be modified to assure consistency. If you have better 
idea, please explain it and I'm willing to change my method.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to