marcoabreu commented on issue #17255: [DO NOT REVIEW]Set np default dtype( 
float32 <-> float64)
URL: https://github.com/apache/incubator-mxnet/pull/17255#issuecomment-572474784
 
 
   Thanks for elaborating, makes sense.
   
   Merging it into set_np sounds like a good addition, indeed.
   
   I know that the code is not ready for review yet, I still have a gut feeling 
that we are approaching this from a strange angle. Sometimes, the dtype 
parameter is removed, sometimes it's set to float, sometimes to none and there 
are probably more cases. 
   
   Do we have a concept how exactly we'd like to have this introduced? Right 
now it feels a bit cluttered and too many things are changed at the same time 
in different ways.
   
   Not trying to criticize here, just trying to give a bit of early input from 
an external view.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to