rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367731063
########## File path: include/mxnet/lib_api.h ########## @@ -763,9 +818,9 @@ typedef int (*opCallInferType_t)(inferType_t, const char* const*, const char* co #define MXLIB_OPCALLFCOMP_STR "_opCallFCompute" typedef int (*opCallFComp_t)(fcomp_t, const char* const*, const char* const*, int, - const int64_t**, int*, void**, int*, size_t*, int, - const int64_t**, int*, void**, int*, size_t*, int, - xpu_malloc_t, void*); + const int64_t**, int*, void**, int*, size_t*, char**, int*, int, + const int64_t**, int*, void**, int*, size_t*, char**, int*, int, + xpu_malloc_t, void*, void*); Review comment: agree ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
