rondogency commented on a change in pull request #17270: [WIP] Dynamic custom
operator GPU support
URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367730693
##########
File path: include/mxnet/lib_api.h
##########
@@ -602,12 +649,18 @@ class CustomOp {
isSGop = true;
return *this;
}
+ ~CustomOp() {}
/*! \brief operator name */
const char* name;
+
+ /*! \brief each fcomp function is associated with a context speficied by a
string*/
+ std::vector<const char*> forward_ctx_cstr;
+ std::vector<fcomp_t> forward_fp;
+ std::vector<const char*> backward_ctx_cstr;
Review comment:
I agree with map can dedup custom registration, but opRegGet needs to pass a
continuous memory to c_api, so let's shelve it now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
