ChaiBapchya commented on a change in pull request #17456: Implement remaining
nn_basic ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17456#discussion_r373266395
##########
File path: benchmark/opperf/nd_operations/nn_basic_operators.py
##########
@@ -16,71 +16,59 @@
# under the License.
import mxnet as mx
-from benchmark.opperf.utils.benchmark_utils import run_performance_test
-from benchmark.opperf.utils.common_utils import merge_map_list
-from benchmark.opperf.rules.default_params import MX_OP_MODULE
+
+from benchmark.opperf.utils.op_registry_utils import get_all_nn_basic_operators
+from benchmark.opperf.utils.benchmark_utils import run_op_benchmarks
"""Performance benchmark tests for MXNet NDArray basic NN Operators.
1. FullyConnected
2. Dropout
3. BatchNorm
+4. SoftmaxOutput
+5. LinearRegressionOutput
+6. LogisticRegressionOutput
+7. MAERegressionOutput
+8. SVMOutput
+9. L2Normalization
+10. LayerNorm
+11. InstanceNorm
+12. Embedding
+13. Correlation
+14. SpatialTransformer
+15. im2col
+16. col2im
+17. GroupNorm
+18. RNN
+19. LRN
"""
def run_nn_basic_operators_benchmarks(ctx=mx.cpu(), dtype='float32',
profiler='native', warmup=25, runs=100):
- # FullyConnnected operator benchmarks
- fc_benchmark_res = run_performance_test([getattr(MX_OP_MODULE,
"FullyConnected")],
- run_backward=True,
- dtype=dtype,
- ctx=ctx,
- profiler=profiler,
- inputs=[{"data": (32, 3, 256, 256),
- "num_hidden": 64,
- "weight": (64, 3 * 256 *
256),
- "bias": (64,),
- "flatten": True},
- {"data": (32, 3, 256, 256),
- "num_hidden": 64,
- "weight": (64, 256),
- "bias": (64,),
- "flatten": False}],
- warmup=warmup,
- runs=runs)
+ """Runs benchmarks with the given context and precision (dtype)for all the
NN basic
+ operators in MXNet.
+
+ Parameters
+ ----------
Review comment:
Good catch.
I handled the rest of the places where profiler is used as a param but I
forgot to add in function description.
I have added them in this PR
https://github.com/apache/incubator-mxnet/pull/17494/files
@connorgoggins you'd still have to add it to nn_basic_ops and
nn_activation_ops (missed that :p)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
