ChaiBapchya commented on a change in pull request #17456: Implement remaining
nn_basic ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17456#discussion_r373267919
##########
File path: benchmark/opperf/utils/op_registry_utils.py
##########
@@ -253,6 +271,27 @@ def get_all_reduction_operators():
reduction_mx_operators[op_name] = mx_operators[op_name]
return reduction_mx_operators
+def get_all_nn_basic_operators():
Review comment:
1. nn_basic ops as a category was already introduced by Sandeep in his
initial opera PR
2. It made sense to keep adding NN layer related ops to this category.
It can be better phrased as nn_layer_ops if that makes sense...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
