szha commented on a change in pull request #17448: cmake: staticbuild for 
binary distribution
URL: https://github.com/apache/incubator-mxnet/pull/17448#discussion_r376052297
 
 

 ##########
 File path: tools/dependencies/opencv.sh
 ##########
 @@ -161,7 +161,7 @@ if [[ ! -f $DEPS_PATH/lib/libopencv_core.a ]] || [[ ! -f 
$DEPS_PATH/lib/libopenc
           -D BUILD_opencv_gpuoptflow=OFF \
           -D BUILD_opencv_gpustereo=OFF \
           -D BUILD_opencv_gpuwarping=OFF \
-          -D BUILD_opencv_highgui=OFF \
+          -D BUILD_opencv_highgui=ON \
 
 Review comment:
   highgui is only needed for very old opencv. we now link with opencv 3.4 in 
which it should not be needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to