leezu commented on a change in pull request #17448: cmake: staticbuild for
binary distribution
URL: https://github.com/apache/incubator-mxnet/pull/17448#discussion_r376172564
##########
File path: tools/dependencies/opencv.sh
##########
@@ -161,7 +161,7 @@ if [[ ! -f $DEPS_PATH/lib/libopencv_core.a ]] || [[ ! -f
$DEPS_PATH/lib/libopenc
-D BUILD_opencv_gpuoptflow=OFF \
-D BUILD_opencv_gpustereo=OFF \
-D BUILD_opencv_gpuwarping=OFF \
- -D BUILD_opencv_highgui=OFF \
+ -D BUILD_opencv_highgui=ON \
Review comment:
Probably because we use "very old" OpenCV on CI. Thus let's keep `-D
BUILD_opencv_highgui=ON`. Unused symbols can be deleted from the library later
anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
