eric-haibin-lin commented on a change in pull request #17555: [MXNET-#16795]
Byteps-KVStore: Intergrate Byteps into mxnet as new type of kvstore backend
URL: https://github.com/apache/incubator-mxnet/pull/17555#discussion_r376731392
##########
File path: python/mxnet/kvstore/base.py
##########
@@ -430,7 +430,7 @@ def create(name='local'):
Parameters
----------
- name : {'local', 'device', 'nccl', 'dist_sync', 'dist_device_sync',
'dist_async', 'horovod'}
+ name : {'local', 'device', 'nccl', 'dist_sync', 'dist_device_sync',
'dist_async', 'horovod', 'byteps'}
Review comment:
Could you add documentation for the new type above and explain what it is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
