eric-haibin-lin commented on a change in pull request #17555: [MXNET-#16795] 
Byteps-KVStore: Intergrate Byteps into mxnet as new type of kvstore backend
URL: https://github.com/apache/incubator-mxnet/pull/17555#discussion_r376731770
 
 

 ##########
 File path: tools/launch.py
 ##########
 @@ -64,13 +64,23 @@ def main():
     parser.add_argument('-H', '--hostfile', type=str,
                         help = 'the hostfile of slave machines which will run \
                         the job. Required for ssh and mpi launcher')
+    parser.add_argument('-SH', '--server-hostfile', type=str,
+                        help = 'the hostfile of server machines which will run 
\
+                        the job. Required for byteps launcher')
 
 Review comment:
   Could you also add:
   when -SH is set, the file provided by -H will be used to recognize worker 
machines only. Otherwise, -H is used for both server and worker machines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to