connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm,
cast ops, remaining optimizer ops
URL: https://github.com/apache/incubator-mxnet/pull/17542#discussion_r377333613
##########
File path: benchmark/opperf/utils/ndarray_utils.py
##########
@@ -75,10 +75,14 @@ def nd_forward_and_profile(op, runs, *args, **kwargs):
any results from NDArray operation execution
"""
for _ in range(runs):
- if not isinstance(args[0], nd.NDArray):
- res = op(**kwargs)
- else:
+ args = []
+ for key in kwargs:
+ if key.startswith("args"):
+ args.append(kwargs.pop(key))
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
