ChaiBapchya commented on a change in pull request #17542: [OpPerf] Add norm,
cast ops, remaining optimizer ops
URL: https://github.com/apache/incubator-mxnet/pull/17542#discussion_r377338540
##########
File path: benchmark/opperf/utils/benchmark_utils.py
##########
@@ -67,28 +61,17 @@ def _run_nd_operator_performance_test(op, inputs,
run_backward, warmup, runs, ar
raise ValueError("Incorrect input for profiler. Valid input - 'python'
or 'native'")
# Warm up, ignore the profiler output
- if not args_list:
- _, _ = benchmark_helper_func(op, warmup, [], **kwargs_list[0])
- else:
- _, _ = benchmark_helper_func(op, warmup, args_list[0],
**kwargs_list[0])
+ _, _ = benchmark_helper_func(op, warmup, **kwargs_list[0])
# Run Benchmarks
op_benchmark_result = {op.__name__: []}
logging.info("Begin Benchmark - {name}".format(name=op.__name__))
- if not args_list:
- for idx, kwargs in enumerate(kwargs_list):
- _, profiler_output = benchmark_helper_func(op, runs, [], **kwargs)
-
- # Add inputs used for profiling this operator into result
- profiler_output["inputs"] = inputs[idx]
- op_benchmark_result[op.__name__].append(profiler_output)
- else:
- for idx, (args, kwargs) in enumerate(zip(args_list, kwargs_list)):
- _, profiler_output = benchmark_helper_func(op, runs, args,
**kwargs)
+ for idx, kwargs in enumerate(kwargs_list):
+ _, profiler_output = benchmark_helper_func(op, runs, [], **kwargs)
Review comment:
Addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
