samskalicky commented on a change in pull request #17530: Add deferred compute
support
URL: https://github.com/apache/incubator-mxnet/pull/17530#discussion_r379847868
##########
File path: src/imperative/cached_op.h
##########
@@ -294,7 +294,7 @@ void SetInputIndices(const nnvm::Graph& fwd_graph,
const auto& indexed_graph = fwd_graph.indexed_graph();
if (data_indices->ndim() || param_indices.ndim()) {
CHECK_EQ(data_indices->ndim() + param_indices.ndim(),
- indexed_graph.input_nodes().size());
+ static_cast<const int>(indexed_graph.input_nodes().size()));
Review comment:
Is this what fixed that weird error
```
[2020-02-05T20:57:05.668Z]
/work/mxnet/3rdparty/mshadow/mshadow/././logging.h:75:34: error: comparison
between signed and unsigned integer expressions [-Werror=sign-compare]
[2020-02-05T20:57:05.668Z] #define CHECK_EQ(x, y) CHECK((x) == (y))
[2020-02-05T20:57:05.668Z] ^
[2020-02-05T20:57:05.668Z]
/work/mxnet/3rdparty/mshadow/mshadow/././logging.h:68:9: note: in definition of
macro 'CHECK'
[2020-02-05T20:57:05.668Z] if (!(x))
\
[2020-02-05T20:57:05.668Z] ^
[2020-02-05T20:57:05.668Z] src/imperative/./cached_op.h:290:5: note: in
expansion of macro 'CHECK_EQ'
[2020-02-05T20:57:05.668Z] CHECK_EQ(data_indices->ndim() +
param_indices.ndim(),
[2020-02-05T20:57:05.668Z] ^
[2020-02-05T20:57:05.668Z] cc1plus: all warnings being treated as errors
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
