leezu commented on a change in pull request #17530: Add deferred compute support
URL: https://github.com/apache/incubator-mxnet/pull/17530#discussion_r381565244
##########
File path: src/imperative/cached_op.h
##########
@@ -294,7 +294,7 @@ void SetInputIndices(const nnvm::Graph& fwd_graph,
const auto& indexed_graph = fwd_graph.indexed_graph();
if (data_indices->ndim() || param_indices.ndim()) {
CHECK_EQ(data_indices->ndim() + param_indices.ndim(),
- indexed_graph.input_nodes().size());
+ static_cast<const int>(indexed_graph.input_nodes().size()));
Review comment:
Was able to reproduce with Makefile based build and older gcc. With that
setup, only
``` c++
#include "./imperative_utils.h"
#include "./cached_op.h"
```
works in `imperative.cc`, but not
``` c++
#include "./cached_op.h"
#include "./imperative_utils.h"
```
which was used in the PR initially due to editor auto-sorting imports by
name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
