samskalicky commented on a change in pull request #17585: Dynamic subgraph
property doc
URL: https://github.com/apache/incubator-mxnet/pull/17585#discussion_r380493090
##########
File path: src/c_api/c_api.cc
##########
@@ -581,19 +582,39 @@ int MXLoadLib(const char *path) {
// FGradient register lambda
auto grad_reg = [=](const nnvm::ObjectPtr& n, const
std::vector<nnvm::NodeEntry>& ograds) {
- // copy gradients first
- std::vector<nnvm::NodeEntry> heads(ograds.begin(), ograds.end());
- // copy inputs second
- for (auto& h : n->inputs) {
- heads.push_back(h);
- }
- // copy outputs last
- uint32_t n_out = n->num_outputs();
- for (uint32_t i = 0; i < n_out; ++i) {
- heads.emplace_back(n, i, 0);
- }
- std::string grad_name = "_backward_" + name_str;
- return mxnet::op::MakeGradNode(grad_name.c_str(), n, heads,
n->attrs.dict);
+ // create node for gradient
+ auto p = nnvm::Node::Create();
+ std::string grad_name = "_backward_" + name_str;
+ p->attrs.op = nnvm::Op::Get(grad_name.c_str());
+ p->attrs.name = n->attrs.name + "_backward";
Review comment:
`grad_name` is the name of the registered FGradient operator which is:
`"_backward_" + name_str`. it will be the same for all backward nodes of that
particular op (think of it as backward op_name)
`p->attrs.name` is the unique name of the particular node in the graph,
which is: `n->attrs.name + "_backward"`. It will be different for backward
nodes of the same op
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
