mseth10 commented on a change in pull request #17585: Dynamic subgraph property
doc
URL: https://github.com/apache/incubator-mxnet/pull/17585#discussion_r380494193
##########
File path: src/c_api/c_api.cc
##########
@@ -724,17 +745,32 @@ int MXLoadLib(const char *path) {
regOp.set_attr<FComputeEx>("FComputeEx<gpu>", forward_gpu_lambda,
plevel);
}
}
- // optionally add fgradient if user specified a function
+ // optionally add fgradient if user specified a function, or for stateful
ops
if (backward_ctx_map.size() != 0 || createop_map.size() != 0) {
- regOp.set_attr<nnvm::FGradient>("FGradient", grad_reg, plevel);
std::string grad_name = "_backward_" + name_str;
nnvm::Op &gradOp =
dmlc::Registry<nnvm::Op>::Get()->__REGISTER_OR_GET__(grad_name);
+ regOp.set_attr<nnvm::FGradient>("FGradient", grad_reg, plevel);
gradOp.set_attr<nnvm::TIsBackward>("TIsBackward", true, plevel);
- gradOp.set_attr_parser(attr_parser);
- gradOp.set_num_inputs(num_inouts);
- gradOp.set_num_outputs(num_inputs);
gradOp.set_attr<FInferStorageType>("FInferStorageType",
infer_storage_type, plevel);
gradOp.set_attr<FResourceRequest>("FResourceRequest", resc_req, plevel);
+
+ if (!isSubgraphOp) {
+ // register attr parser and standard functions for non-subgraph ops
+ gradOp.set_attr_parser(attr_parser);
+ gradOp.set_num_inputs(num_inouts);
+ gradOp.set_num_outputs(num_inputs);
+ } else {
+ // for subgraph ops use special functions
+ using namespace mxnet::op;
+ auto grad_inouts = [=](const nnvm::NodeAttrs& attrs) {
+ uint32_t cnt = DefaultSubgraphOpNumInputs(attrs);
+ cnt += 2 * DefaultSubgraphOpNumOutputs(attrs);
+ return cnt;
+ };
+ gradOp.set_num_inputs(grad_inouts);
+ gradOp.set_num_outputs(DefaultSubgraphOpNumInputs);
Review comment:
are we assigning a function `DefaultSubgraphOpNumInputs` as number of
outputs? shouldn't it be a variable as for inputs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
