apeforest commented on a change in pull request #17645: [CI] Test CMake builds
instead of Makefile builds
URL: https://github.com/apache/incubator-mxnet/pull/17645#discussion_r382421140
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -455,36 +437,40 @@ build_ubuntu_cpu() {
build_ubuntu_cpu_openblas() {
set -ex
- export CC="gcc"
- export CXX="g++"
- build_ccache_wrappers
- make \
- DEV=1 \
- USE_TVM_OP=1 \
- USE_CPP_PACKAGE=1 \
- USE_BLAS=openblas \
- USE_MKLDNN=0 \
- USE_DIST_KVSTORE=1 \
- USE_LIBJPEG_TURBO=1 \
- USE_SIGNAL_HANDLER=1 \
- -j$(nproc)
- make cython PYTHON=python3
+ pushd .
+ cmake \
+ -DCMAKE_BUILD_TYPE="RelWithDebInfo" \
+ -DUSE_TVM_OP=ON \
+ -DUSE_CPP_PACKAGE=ON \
+ -DUSE_MKL_IF_AVAILABLE=OFF \
+ -DUSE_MKLDNN=OFF \
+ -DUSE_CUDA=OFF \
+ -DUSE_DIST_KVSTORE=ON \
+ -DBUILD_CYTHON_MODULES=ON \
+ -DUSE_LIBJPEG_TURBO=ON \
+ -G Ninja /work/mxnet
+ ninja
+ popd
}
build_ubuntu_cpu_mkl() {
set -ex
- export CC="ccache gcc"
- export CXX="ccache g++"
- make \
- DEV=1 \
- USE_CPP_PACKAGE=1 \
- USE_BLAS=mkl \
- USE_TVM_OP=1 \
- USE_MKLDNN=0 \
- USE_INTEL_PATH=/opt/intel \
- USE_DIST_KVSTORE=1 \
- USE_SIGNAL_HANDLER=1 \
- -j$(nproc)
+ pushd .
+ cmake \
+ -DCMAKE_BUILD_TYPE="RelWithDebInfo" \
+ -DUSE_TVM_OP=ON \
Review comment:
I think we should turn off this by default and create a separate to test
TVM_ON instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
