apeforest commented on a change in pull request #17645: [CI] Test CMake builds
instead of Makefile builds
URL: https://github.com/apache/incubator-mxnet/pull/17645#discussion_r382421518
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -735,96 +713,93 @@ build_ubuntu_gpu_tensorrt() {
build_ubuntu_gpu_mkldnn() {
set -ex
-
- build_ccache_wrappers
-
- make \
- DEV=1 \
- USE_CPP_PACKAGE=1 \
- USE_BLAS=openblas \
- USE_CUDA=1 \
- USE_CUDA_PATH=/usr/local/cuda \
- USE_CUDNN=1 \
- USE_TVM_OP=1 \
- CUDA_ARCH="$CI_CUDA_COMPUTE_CAPABILITIES" \
- USE_SIGNAL_HANDLER=1 \
- -j$(nproc)
+ pushd .
+ cd /work/build
+ cmake \
+ -DCMAKE_BUILD_TYPE="RelWithDebInfo" \
+ -DUSE_MKL_IF_AVAILABLE=OFF \
+ -DUSE_TVM_OP=ON \
+ -DUSE_CUDA=ON \
+ -DMXNET_CUDA_ARCH="$CI_CMAKE_CUDA_ARCH" \
+ -DUSE_CPP_PACKAGE=ON \
+ -G Ninja /work/mxnet
+ ninja
+ popd
}
build_ubuntu_gpu_mkldnn_nocudnn() {
set -ex
-
- build_ccache_wrappers
-
- make \
- DEV=1 \
- USE_BLAS=openblas \
- USE_CUDA=1 \
- USE_CUDA_PATH=/usr/local/cuda \
- USE_CUDNN=0 \
- USE_TVM_OP=1 \
- CUDA_ARCH="$CI_CUDA_COMPUTE_CAPABILITIES" \
- USE_SIGNAL_HANDLER=1 \
- -j$(nproc)
+ pushd .
+ cd /work/build
+ cmake \
+ -DCMAKE_BUILD_TYPE="RelWithDebInfo" \
+ -DUSE_MKL_IF_AVAILABLE=OFF \
+ -DUSE_TVM_OP=ON \
+ -DUSE_CUDA=ON \
+ -DMXNET_CUDA_ARCH="$CI_CMAKE_CUDA_ARCH" \
+ -DUSE_CUDNN=OFF \
+ -DUSE_CPP_PACKAGE=ON \
+ -G Ninja /work/mxnet
+ ninja
+ popd
}
build_ubuntu_gpu_cuda101_cudnn7() {
set -ex
- build_ccache_wrappers
- make \
- DEV=1 \
- USE_BLAS=openblas \
- USE_MKLDNN=0 \
- USE_CUDA=1 \
- USE_CUDA_PATH=/usr/local/cuda \
- USE_CUDNN=1 \
- USE_TVM_OP=1 \
- USE_CPP_PACKAGE=1 \
- USE_DIST_KVSTORE=1 \
- CUDA_ARCH="$CI_CUDA_COMPUTE_CAPABILITIES" \
- USE_SIGNAL_HANDLER=1 \
- -j$(nproc)
- make cython PYTHON=python3
+ pushd .
+ cd /work/build
+ cmake \
+ -DCMAKE_BUILD_TYPE="RelWithDebInfo" \
+ -DUSE_MKL_IF_AVAILABLE=OFF \
+ -DUSE_TVM_OP=ON \
+ -DUSE_CUDA=ON \
+ -DMXNET_CUDA_ARCH="$CI_CMAKE_CUDA_ARCH" \
+ -DUSE_CUDNN=ON \
+ -DUSE_MKLDNN=OFF \
+ -DUSE_CPP_PACKAGE=ON \
+ -DBUILD_CYTHON_MODULES=ON \
+ -G Ninja /work/mxnet
+ ninja
+ popd
}
build_ubuntu_gpu_cuda101_cudnn7_mkldnn_cpp_test() {
set -ex
- build_ccache_wrappers
- make \
- DEV=1 \
- USE_BLAS=openblas \
- USE_MKLDNN=1 \
- USE_CUDA=1 \
- USE_CUDA_PATH=/usr/local/cuda \
- USE_CUDNN=1 \
- USE_TVM_OP=0 \
- USE_CPP_PACKAGE=1 \
- USE_DIST_KVSTORE=1 \
- CUDA_ARCH="$CI_CUDA_COMPUTE_CAPABILITIES" \
- USE_SIGNAL_HANDLER=1 \
- -j$(nproc)
- make test USE_CPP_PACKAGE=1 -j$(nproc)
- make cython PYTHON=python3
+ pushd .
+ cd /work/build
+ cmake \
+ -DCMAKE_BUILD_TYPE="RelWithDebInfo" \
+ -DUSE_MKL_IF_AVAILABLE=OFF \
+ -DUSE_TVM_OP=OFF \
+ -DUSE_CUDA=ON \
+ -DMXNET_CUDA_ARCH="$CI_CMAKE_CUDA_ARCH" \
+ -DUSE_CUDNN=ON \
+ -DUSE_MKLDNN=ON \
+ -DUSE_CPP_PACKAGE=ON \
+ -DBUILD_CYTHON_MODULES=ON \
+ -DUSE_DIST_KVSTORE=ON \
+ -G Ninja /work/mxnet
+ ninja
+ popd
}
build_ubuntu_gpu_cuda101_cudnn7_no_tvm_op() {
set -ex
- build_ccache_wrappers
- make \
- DEV=1 \
- USE_BLAS=openblas \
- USE_MKLDNN=0 \
- USE_CUDA=1 \
- USE_CUDA_PATH=/usr/local/cuda \
- USE_CUDNN=1 \
- USE_TVM_OP=0 \
- USE_CPP_PACKAGE=1 \
- USE_DIST_KVSTORE=1 \
- CUDA_ARCH="$CI_CUDA_COMPUTE_CAPABILITIES" \
- USE_SIGNAL_HANDLER=1 \
- -j$(nproc)
-
- make cython PYTHON=python3
+ pushd .
+ cd /work/build
+ cmake \
+ -DCMAKE_BUILD_TYPE="RelWithDebInfo" \
+ -DUSE_MKL_IF_AVAILABLE=OFF \
+ -DUSE_TVM_OP=OFF \
Review comment:
I think we should change this to TVM_OP = ON and rename this test to
`build_ubuntu_gpu_cuda101_cudnn7_tvm_op()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
