TaoLv commented on a change in pull request #17645: [CI] Test CMake builds
instead of Makefile builds
URL: https://github.com/apache/incubator-mxnet/pull/17645#discussion_r384310491
##########
File path: cmake/Modules/FindMKL.cmake
##########
@@ -122,10 +126,9 @@ set(INTEL_ROOT "/opt/intel" CACHE PATH "Folder contains
intel libs")
list(APPEND MKL_LIBRARIES ${${__mkl_lib_upper}_LIBRARY})
endforeach()
-
if(NOT MKL_USE_SINGLE_DYNAMIC_LIBRARY)
- if (MKL_USE_STATIC_LIBS)
- set(__iomp5_libs iomp5 libiomp5mt.lib)
+ if (MKL_USE_STATIC_LIBS AND UNIX)
+ set(__iomp5_libs libiomp5.a libiomp5mt.lib)
Review comment:
Hmm, why we need static link libiomp5.a?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
