rondogency opened a new pull request #17762: Custom Operator Random Number 
Generator Support
URL: https://github.com/apache/incubator-mxnet/pull/17762
 
 
   ## Description ##
   Add random number generator support for custom operator libraries. 
   
   Custom library now can call MXNet random number generator to get random 
numbers through OpResource class in forward/backward computation.
   
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   
   ### Changes ###
   - change lib_api.h OpResource class to support all random number generator 
API calls and returns the generated number
   - change c_api.cc to init the RandomGenerator object when custom library 
invokes any API calls, and eventually invokes MXNet functions to generator 
random numbers
   - currently we use GPU RNG whenever possible
   
   
   ## Comments ##
   this is a continuation of the custom operator project #15921 and #17270 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to