samskalicky commented on a change in pull request #17569: Adding sparse support 
to MXTensor for custom operators
URL: https://github.com/apache/incubator-mxnet/pull/17569#discussion_r392017757
 
 

 ##########
 File path: include/mxnet/lib_api.h
 ##########
 @@ -393,13 +458,21 @@ class OpResource {
     return static_cast<mx_stream_t>(cuda_stream);
   }
 
+  void alloc_ndarray(MXSparse* sparse, int index, int indices_len, int 
indptr_len = 0) {
 
 Review comment:
   should we call this "alloc_sparse" so that users dont try and use it for 
general ndarray allocation? especially since it takes a sparse tensor as input.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to