wkcn commented on a change in pull request #17569: Adding sparse support to
MXTensor for custom operators
URL: https://github.com/apache/incubator-mxnet/pull/17569#discussion_r394049408
##########
File path: include/mxnet/lib_api.h
##########
@@ -1102,7 +1232,12 @@ extern "C" {
const int64_t** outshapes, int* outdims, void** outdata,
int* outtypes,
size_t* outIDs, const char** outdev_type, int* outdev_id,
int num_out,
xpu_malloc_t cpu_malloc, void* cpu_alloc,
- xpu_malloc_t gpu_malloc, void* gpu_alloc, void* cuda_stream)
{
+ xpu_malloc_t gpu_malloc, void* gpu_alloc, void* cuda_stream,
+ sparse_malloc_t sparse_malloc, void* sparse_alloc,
+ int* instypes, int* outstypes, void** in_indices, void**
out_indices,
+ void** in_indptr, void** out_indptr,
+ int64_t* in_indices_shapes, int64_t* out_indices_shapes,
+ int64_t* in_indptr_shapes, int64_t* out_indptr_shapes) {
Review comment:
There are too many arguments in a function. We can use C structure to reduce
the number of arguments later in other PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
