wkcn commented on a change in pull request #17569: Adding sparse support to
MXTensor for custom operators
URL: https://github.com/apache/incubator-mxnet/pull/17569#discussion_r394048814
##########
File path: include/mxnet/lib_api.h
##########
@@ -1111,20 +1246,60 @@ extern "C" {
// create a vector of tensors for inputs
std::vector<MXTensor> inputs(num_in);
+ // create a vector for sparse inputs
+ std::vector<MXSparse> in_sparse(num_in);
Review comment:
I think it will save the memory space to use `std::vector<MXTensor*> and
std::vector<MXSparse*>`, or a union which contains the pointers of `MXTensor`
and `Sparse`. However, it is a small thing : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
