sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394377382
########## File path: CMakeLists.txt ########## @@ -704,6 +712,8 @@ if(UNIX) target_link_libraries(mxnet PRIVATE mxnet_static) target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS}) set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet) + set_target_properties(mxnet PROPERTIES VERSION "${ver_major}.${ver_minor}.${ver_patch}") Review comment: other test, and this surprise me, i just add ~~~cmake message(STATUS "Project version: ${PROJECT_VERSION}") ~~~ just before `project()` function, and works ![Screenshot_20200318_151002](https://user-images.githubusercontent.com/462213/76969342-8d657180-692a-11ea-95bc-bb7401e81fae.png) but is vanished if put that in the bottom/middle of the CMakeLists ![Screenshot_20200318_151423](https://user-images.githubusercontent.com/462213/76969787-2ac0a580-692b-11ea-8eb2-e1fed938adbc.png) ![Screenshot_20200318_151156](https://user-images.githubusercontent.com/462213/76969551-d1587680-692a-11ea-810b-b8d1fba0947a.png) cmake is a bit complex for me, IDK where is the problem, so, i think is better keep untounch with `${ver_major}.${ver_minor}.${ver_patch}` and in near future (when i found the problem), fix it greetings ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services