sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394398634
##########
File path: CMakeLists.txt
##########
@@ -704,6 +712,8 @@ if(UNIX)
target_link_libraries(mxnet PRIVATE mxnet_static)
target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+ set_target_properties(mxnet PROPERTIES VERSION
"${ver_major}.${ver_minor}.${ver_patch}")
Review comment:
i think is finally done
tested on local and works as spected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
