samskalicky commented on a change in pull request #17762: Custom Operator
Random Number Generator Support
URL: https://github.com/apache/incubator-mxnet/pull/17762#discussion_r399045512
##########
File path: include/mxnet/lib_api.h
##########
@@ -437,10 +438,12 @@ class OpResource {
public:
OpResource(xpu_malloc_t cpu_malloc_fp, void* cpu_alloc_fp,
xpu_malloc_t gpu_malloc_fp, void* gpu_alloc_fp, void* stream,
- sparse_malloc_t sparse_malloc_fp, void* sparse_alloc_fp)
+ sparse_malloc_t sparse_malloc_fp, void* sparse_alloc_fp,
+ void* cpu_states, void* gpu_states)
Review comment:
can we call these cpu_rand_states and gpu_rand_states so that its clear that
these are for the RNG?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
