samskalicky commented on a change in pull request #17762: Custom Operator
Random Number Generator Support
URL: https://github.com/apache/incubator-mxnet/pull/17762#discussion_r399046049
##########
File path: include/mxnet/lib_api.h
##########
@@ -997,7 +1015,8 @@ typedef int (*opCallFComp_t)(fcomp_t fcomp, const char*
const* keys,
void** in_indices, void** out_indices,
void** in_indptr, void** out_indptr,
int64_t* in_indices_shapes, int64_t*
out_indices_shapes,
- int64_t* in_indptr_shapes, int64_t*
out_indptr_shapes);
+ int64_t* in_indptr_shapes, int64_t*
out_indptr_shapes,
+ void* cpu_states, void* gpu_states);
Review comment:
can we call these rand_ cpu_states and rand_gpu_states (or something with
rng/rand in it) so its more clear that these are for RNG?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
