apeforest commented on a change in pull request #17882: Improve performance of broadcast_axis URL: https://github.com/apache/incubator-mxnet/pull/17882#discussion_r410368675
########## File path: src/operator/tensor/broadcast_reduce_op.h ########## @@ -1090,6 +1118,7 @@ inline void BroadcastComputeImpl(const nnvm::NodeAttrs& attrs, mxnet::TShape src_shape, dst_shape; BroadcastReduceShapeCompact(outputs[0].shape_, small, &dst_shape, &src_shape); Stream<xpu> *s = ctx.get_stream<xpu>(); + bool enable_lt = dst_shape.Size() > INT_MAX; Review comment: Let's remove this flag and check the performance gain. If indeed we need to handle int64 case differently we need a more holistic design. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
