apeforest commented on a change in pull request #17882:
URL: https://github.com/apache/incubator-mxnet/pull/17882#discussion_r411749878
##########
File path: src/operator/numpy/np_matmul_op-inl.h
##########
@@ -157,12 +157,50 @@ inline void MatmulImpl(const OpContext& ctx,
DType* bc_b_ptr = bc_a_ptr + bc_size_a;
MSHADOW_TYPE_SWITCH_WITH_BOOL(input_a.type_flag_, IType, {
MSHADOW_TYPE_SWITCH_WITH_BOOL(input_b.type_flag_, OType, {
- Kernel<broadcast_kernel<mshadow_op::identity>, xpu>::Launch(
- s, bc_size_a, input_a.dptr<IType>(), bc_a_ptr,
- k_a_shape, k_a_shape_bc, OpReqType::kWriteTo, ndim);
- Kernel<broadcast_kernel<mshadow_op::identity>, xpu>::Launch(
- s, bc_size_b, input_b.dptr<IType>(), bc_b_ptr,
- k_b_shape, k_b_shape_bc, OpReqType::kWriteTo, ndim);
+ bool a_shape_changed = false, b_shape_changed = false;
+ size_t axes[ndim], out_stride[ndim], axes_b[ndim], out_stride_b[ndim];
+ int iter = ndim - 1, idx_a = 0, idx_b = 0;
+ out_stride[iter] = 1;
Review comment:
should this be named out_stride_a?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
