leezu commented on pull request #18445: URL: https://github.com/apache/incubator-mxnet/pull/18445#issuecomment-639866654
@ma-hei > I'm now wondering if the failure in "continuous build / macosx-x86_64" that I'm seeing below is already a consequence of the onnx update I made (which is necessary in order to update to python 3.8, which in turn is the goal of this PR). > My question is basically: what is each of the CI jobs below doing? In which of the jobs below should I be able to observe the test failures? ONNX 1.6 appears to have some major changes (cf. discussion in https://github.com/apache/incubator-mxnet/pull/18054). So it's possible that updating ONNX leads to test failures. The Ubuntu container you're modifying here is used for the ubuntu-cpu and ubuntu-gpu jobs. So you'd start seeing Python 3.8 related failures there. But the requirement file you modified is shared among all containers. So you may want to use https://www.python.org/dev/peps/pep-0508/#environment-markers feature to only update ONNX when running under Python 3.8 and then disable or fix the ONNX tests in the unix-cpu and unix-gpu pipeline. Alternatively you can try building ONNX 1.5 for Py 3.8 from source https://github.com/onnx/onnx#linux-and-macos @RuRo what do you think? > Also let me know if you think this is going down a wrong route and I should try something different. I think your current steps are fine ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
