ma-hei edited a comment on pull request #18445: URL: https://github.com/apache/incubator-mxnet/pull/18445#issuecomment-643807772
@leezu I think I got to a state where I can run the unittests with python3.8 and reproduce what is described in the issue ticket https://github.com/apache/incubator-mxnet/issues/18380 I ignored the lint errors for now by adding disable flags to the pylintrc file. As described in https://github.com/apache/incubator-mxnet/issues/18380 we're seeing an issue related to the usage of time.clock(). Besides that, I found the following issue: The test tests/python/unittest/onnx/test_node.py::TestNode::test_import_export seems to fail. In the Jenkins job I don't see the error, but when running the test locally with python3.8 and onnx 1.7, I'm getting: ``` > bkd_rep = backend.prepare(onnxmodel, operation='export', backend='mxnet') tests/python/unittest/onnx/test_node.py:164: tests/python/unittest/onnx/backend.py:104: in prepare sym, arg_params, aux_params = MXNetBackend.perform_import_export(sym, arg_params, aux_params, tests/python/unittest/onnx/backend.py:62: in perform_import_export graph_proto = converter.create_onnx_graph_proto(sym, params, in_shape=input_shape, python/mxnet/contrib/onnx/mx2onnx/export_onnx.py:308: in create_onnx_graph_proto ... E onnx.onnx_cpp2py_export.checker.ValidationError: Node (pad0) has input size 1 not in range [min=2, max=3]. E E ==> Context: Bad node spec: input: "input1" output: "pad0" name: "pad0" op_type: "Pad" attribute { name: "mode" s: "constant" type: STRING } attribute { name: "pads" ints: 0 ints: 0 ints: 0 ints: 0 in ts: 0 ints: 0 ints: 0 ints: 0 type: INTS } attribute { name: "value" f: 0 type: FLOAT } ../../../Library/Python/3.8/lib/python/site-packages/onnx/checker.py:53: ValidationError ``` I believe this is an issue in onnx 1.7 as it looks exactly like https://github.com/onnx/onnx/issues/2548. I also found that the test job Python3: MKL-CPU is not running through which seems to be due to a Timeout. I believe this is happening in test tests/python/conftest.py but the log output is not telling me which test is failing and I can run the test successfully locally. Do you have any idea how to reproduce this locally, or to get better insight into that failure? I will now look into the following: - can I work around the onnx 1.7 related issue? - even after aligning pylint and astroid, I'm seeing unexpected linting errors. The linter is telling me that ndarray is a bad class name. Why is that happening? Btw. I believe that you and @marcoabreu are getting pinged every time I do a commit to this PR. I don't think this PR is actually in a reviewable state yet but the purpose of it is more to see what's breaking when upgrading to Python3.8. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
