AntiZpvoh commented on a change in pull request #18319:
URL: https://github.com/apache/incubator-mxnet/pull/18319#discussion_r453143466
##########
File path: python/mxnet/numpy/multiarray.py
##########
@@ -720,6 +720,28 @@ def __getitem__(self, key):
key = (_np.newaxis,) + key
return self._get_np_basic_indexing(key)
elif indexing_dispatch_code == _NDARRAY_ADVANCED_INDEXING:
+ if prepend == _NDARRAY_NO_ZERO_DIM_BOOL_ARRAY and isinstance(key,
(NDArray, _np.ndarray)):
Review comment:
Thanks for reviewing my code @leezu ! Actually for now my op does not
cover newaxis indexing case in backend since the primary purpose of this PR is
to solve the issue #17327 (support indexing like sequence[indices_x, indices_y]
after hybridized). This is why this if statement is so complex. And I have
updated feature request https://github.com/apache/incubator-mxnet/issues/18627
to add feature request for supporting np.newaxis and implicit axis index.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
