AntiZpvoh commented on a change in pull request #18319:
URL: https://github.com/apache/incubator-mxnet/pull/18319#discussion_r453168025
##########
File path: python/mxnet/numpy/multiarray.py
##########
@@ -720,6 +720,28 @@ def __getitem__(self, key):
key = (_np.newaxis,) + key
return self._get_np_basic_indexing(key)
elif indexing_dispatch_code == _NDARRAY_ADVANCED_INDEXING:
+ if prepend == _NDARRAY_NO_ZERO_DIM_BOOL_ARRAY and isinstance(key,
(NDArray, _np.ndarray)):
Review comment:
@leezu My apology I found my mistake. It should be `isinstance(key,
tuple)` instead of `isinstance(key, (NDArray, _np.ndarray))`. In that case
codepath needs to be complex since we need to ensure the element of tuple is
integer NDArray or np.ndarray (cannot be list maybe because list could not be
symbolized) and also handle np.newaxis and implicit axis cases. The newest
commit has already corrected this mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
