szha commented on a change in pull request #9273: Enhancements to the build 
mechanism
URL: https://github.com/apache/incubator-mxnet/pull/9273#discussion_r159163589
 
 

 ##########
 File path: Makefile
 ##########
 @@ -231,11 +243,11 @@ ifeq ($(USE_THREADED_ENGINE), 1)
 endif
 
 ifneq ($(ADD_CFLAGS), NONE)
-       CFLAGS += $(ADD_CFLAGS)
+       CFLAGS := $(ADD_CFLAGS) $(CFLAGS)
 
 Review comment:
   Why does the order of the flags need to change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to