szha commented on a change in pull request #9273: Enhancements to the build
mechanism
URL: https://github.com/apache/incubator-mxnet/pull/9273#discussion_r160040593
##########
File path: Makefile
##########
@@ -210,10 +214,18 @@ ifneq ($(USE_GPERFTOOLS), 1)
endif
endif
endif
+ JEMALLOC_CUSTOM=$(shell pkg-config --exists jemalloc; echo $$?)
+ ifeq ($(JEMALLOC_CUSTOM), 0)
+ CFLAGS += $(shell pkg-config --cflags jemalloc)
+ LDFLAGS += $(shell pkg-config --libs jemalloc)
Review comment:
Maybe use a name that's more informative, such as USE_JEMALLOC_PATH, and let
the none case perform the pkg-config look-up? BTW thanks for making this
change. This is useful for statically linking jemalloc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
