piiswrong commented on a change in pull request #8972: Profiling enhancements,
python API, vtune and chrome tracing objects, etc.
URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r156565366
##########
File path: src/engine/naive_engine.cc
##########
@@ -130,22 +125,17 @@ class NaiveEngine final : public Engine {
NaiveEngine::OnComplete, nullptr);
this->req_completed_ = false;
#if MXNET_USE_PROFILER
- Profiler *profiler = Profiler::Get();
+ profile::Profiler *profiler = profile::Profiler::Get();
NaiveOpr *opr = nullptr;
- bool profiling = (profiler->GetState() == Profiler::kRunning) &&
- (profiler->GetMode() == Profiler::kAllOperator) &&
+ bool profiling = (profiler->GetState() == profile::Profiler::kRunning) &&
Review comment:
add profiler->IsEnabledFor(mode)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
