piiswrong commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r156562684
########## File path: include/mxnet/c_api.h ########## @@ -211,13 +213,12 @@ MXNET_DLL int MXRandomSeed(int seed); MXNET_DLL int MXNotifyShutdown(); /*! * \brief Set up configuration of profiler - * \param mode indicate the working mode of profiler, - * record anly symbolic operator when mode == 0, - * record all operator when mode == 1 + * \param mode indicate the working mode of profiler * \param filename where to save trace file + * \param append_mode Whether DumpProfile() call should append to the same profile data file * \return 0 when success, -1 when failure happens. */ -MXNET_DLL int MXSetProfilerConfig(int mode, const char* filename); +MXNET_DLL int MXSetProfilerConfig(const char *mode, const char* filename, int append_mode); Review comment: change to kwargs ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
