yuxiangw commented on a change in pull request #9220: Signum optimizer
URL: https://github.com/apache/incubator-mxnet/pull/9220#discussion_r159714768
##########
File path: src/operator/optimizer_op-inl.h
##########
@@ -1088,6 +1090,146 @@ inline void FtrlUpdateEx(const nnvm::NodeAttrs& attrs,
}
}
+
+// Implementation for signSGD and Signum
+
+struct SignSGDParam : public dmlc::Parameter<SignSGDParam> {
+ float lr;
+ float wd;
+ float rescale_grad;
+ float clip_gradient;
Review comment:
It has an effect on Signum. Because it will lead to different result whether
we use gradient or clipped gradient for calculating momentum.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
