yuxiangw commented on a change in pull request #9220: Signum optimizer URL: https://github.com/apache/incubator-mxnet/pull/9220#discussion_r159721991
########## File path: src/operator/optimizer_op.cc ########## @@ -35,6 +35,74 @@ DMLC_REGISTER_PARAMETER(AdamParam); DMLC_REGISTER_PARAMETER(RMSPropParam); DMLC_REGISTER_PARAMETER(RMSPropAlexParam); DMLC_REGISTER_PARAMETER(FtrlParam); +DMLC_REGISTER_PARAMETER(SignSGDParam); +DMLC_REGISTER_PARAMETER(SignumParam); + +NNVM_REGISTER_OP(signsgd_update) +// MXNET_ADD_SPARSE_OP_ALIAS(signsgd_update) +.describe(R"code(Update function for SignSGDoptimizer. Review comment: done. and added the math description block similar to other optimizers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
