zheng-da commented on issue #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#issuecomment-357778866 Thanks for helping review the code. @rahul003 @cjolivier01 @reminisce @eric-haibin-lin @piiswrong @szha The design document of this integration is here: https://cwiki.apache.org/confluence/display/MXNET/The+design+of+MKLDNN+integration Here is a list of files where modifications are required to integrate mkldnn with the mxnet executor. Can all of you review the code? include/mxnet/ndarray.h include/mxnet/tensor_blob.h src/common/exec_utils.h src/executor/attach_op_execs_pass.cc src/executor/graph_executor.cc src/executor/infer_graph_attr_pass.cc src/imperative/cached_op.cc src/imperative/imperative_utils.h src/kvstore/kvstore_dist.h src/kvstore/kvstore_local.h src/ndarray/ndarray.cc src/operator/tensor/cast_storage-inl.h src/operator/tensor/cast_storage.cc src/storage/cpu_device_storage.h tests/cpp/include/test_core_op.h These files contains the wrapper functions for all MKLDNN operators. Can all of you review them? src/operator/nn/mkldnn/mkldnn_base.cc src/operator/nn/mkldnn/mkldnn_base-inl.h These files are modified for MKLDNN sum and copy. @eric-haibin-lin could you review them? src/operator/tensor/elemwise_binary_op_basic.cc src/operator/tensor/elemwise_binary_scalar_op_basic.cc src/operator/tensor/elemwise_sum.cc src/operator/tensor/elemwise_unary_op_basic.cc src/operator/tensor/matrix_op.cc src/operator/nn/mkldnn/mkldnn_sum.cc src/operator/nn/mkldnn/mkldnn_copy.cc @szha could you review them? src/operator/nn/mkldnn/mkldnn_act.cc src/operator/nn/activation.cc src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h src/operator/nn/batch_norm.cc @piiswrong could you review them? src/operator/nn/mkldnn/mkldnn_concat.cc src/operator/nn/concat.cc src/operator/nn/mkldnn/mkldnn_convolution.cc src/operator/nn/convolution.cc @cjolivier01 could you review them? src/operator/nn/mkldnn/mkldnn_deconvolution.cc src/operator/nn/deconvolution.cc src/operator/nn/mkldnn/mkldnn_fully_connected.cc src/operator/nn/fully_connected.cc @reminisce could you review them? src/operator/nn/mkldnn/mkldnn_lrn-inl.h src/operator/nn/lrn.cc src/operator/nn/mkldnn/mkldnn_pooling-inl.h src/operator/nn/pooling.cc @rahul003 could you review them? src/operator/nn/mkldnn/mkldnn_softmax.cc src/operator/nn/softmax.cc @marcoabreu could you review the modification on Jenkinsfile? ./Jenkinsfile The rest of the files are code refactoring of the neural network operators. I tried my best to not modify them as much as possible. Could you scan them to double check?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
